Comment by 🐙 cthulhu

@skyjake, it is typo in id type in `documentwidget.c:documentWasChanged_DocumentWidget_`.

`uint16_t` is too small for `uint32_t` bookmark id. Truncated id, not found bookmark, iBookmark is NULL.

-    const uint16_t bmid = findBookmarkId_DocumentWidget(d);
+    const uint32_t bmid = findBookmarkId_DocumentWidget(d);

🐙 cthulhu

Feb 25 · 5 months ago

2 Later Comments ↓

🐙 cthulhu · Feb 25 at 03:22:

— Fixed: Bookmarks crash with correct id type (uint16_t -> uint32_t) #4

🏕️ skyjake [mod...] · Feb 25 at 05:32:

That would explain it, yes. I'm still planning on fixing the ID number inflation, as that seems like an issue that eventually triggers an overflow anyway.

Original Post

🌒 s/Lagrange-Issues

— example

The application crashes (it closes) when I save certain addresses as bookmarks and then try to visit them by selecting from the bookmarks; for example, this happens with the URL [gemini link]

💬 astio · 11 comments · 2024-10-26 · 8 months ago · #bug

Source