Comment by ๐Ÿ•๏ธ skyjake

Re: "Bookmark ID number overflow"

In: s/Lagrange-Issues

Thanks for the details. If the problem is with the numbering, I can always force a renumbering to avoid the unnecessary range inflation.

๐Ÿ•๏ธ skyjake [mod, sysop]

2024-10-30 ยท 8 months ago

4 Later Comments โ†“

๐Ÿ™ cthulhu ยท Feb 24 at 00:26:

Also affected: Android 1.18 (Beta 35); Linux 1.18.4;

Bookmark:

[77539]
url = "gemini://salixos.org/"
title = "Linux for the lazy Slacker"
tags = ".usericon"
icon = 0x1f30a
created = 1740352870  # 2025-02-24
order = 100

๐Ÿ™ cthulhu ยท Feb 25 at 02:57:

@skyjake, it is typo in id type in `documentwidget.c:documentWasChanged_DocumentWidget_`.

`uint16_t` is too small for `uint32_t` bookmark id. Truncated id, not found bookmark, iBookmark is NULL.

-    const uint16_t bmid = findBookmarkId_DocumentWidget(d);
+    const uint32_t bmid = findBookmarkId_DocumentWidget(d);

๐Ÿ™ cthulhu ยท Feb 25 at 03:22:

โ€” Fixed: Bookmarks crash with correct id type (uint16_t -> uint32_t) #4

๐Ÿ•๏ธ skyjake [mod...] ยท Feb 25 at 05:32:

That would explain it, yes. I'm still planning on fixing the ID number inflation, as that seems like an issue that eventually triggers an overflow anyway.

Original Post

๐ŸŒ’ s/Lagrange-Issues

โ€” example

The application crashes (it closes) when I save certain addresses as bookmarks and then try to visit them by selecting from the bookmarks; for example, this happens with the URL [gemini link]

๐Ÿ’ฌ astio ยท 11 comments ยท 2024-10-26 ยท 8 months ago ยท #bug


Source